Skip to content

Fixed fuzzies in library/unittest.po#1004

Merged
christopheNan merged 6 commits into
python:3.8from
Seluj78:fuzzies-unittest
Dec 15, 2019
Merged

Fixed fuzzies in library/unittest.po#1004
christopheNan merged 6 commits into
python:3.8from
Seluj78:fuzzies-unittest

Conversation

@Seluj78

@Seluj78 Seluj78 commented Nov 17, 2019

Copy link
Copy Markdown
Collaborator

Oui je sais j'ai mis une virgule et un point à la ligne 2427 mais c'est déjà dans les tuyaux !

python/cpython#17211

@Seluj78 Seluj78 added the NEED REVIEWER This PR needs a reviewer :) label Nov 17, 2019
@Seluj78 Seluj78 self-assigned this Nov 17, 2019

@vpoulailleau vpoulailleau left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Padpo donne plein de warnings pour ce fichier, je t'ai remonté les remarques sur les parties que tu as modifiées.

Comment thread library/unittest.po Outdated
Comment thread library/unittest.po Outdated
Comment thread library/unittest.po Outdated
Comment thread library/unittest.po Outdated
Comment thread library/unittest.po Outdated
Co-Authored-By: Vincent Poulailleau <vpoulailleau@gmail.com>
Comment thread library/unittest.po Outdated
Comment thread library/unittest.po
Comment thread library/unittest.po Outdated
Comment thread library/unittest.po Outdated
Comment thread library/unittest.po Outdated
Comment thread library/unittest.po Outdated
Comment thread library/unittest.po Outdated
Comment thread library/unittest.po Outdated
Comment thread library/unittest.po Outdated
Co-Authored-By: Christophe Nanteuil <35002064+christopheNan@users.noreply.github.com>

@vpoulailleau vpoulailleau left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C'est padpo ! (je m'en lasse pas de cette blague pourrie 😉)

Comment thread library/unittest.po Outdated
@Seluj78

Seluj78 commented Dec 13, 2019

Copy link
Copy Markdown
Collaborator Author

Done @vpoulailleau @christopheNan

@Seluj78 Seluj78 removed the NEED REVIEWER This PR needs a reviewer :) label Dec 13, 2019
christopheNan
christopheNan previously approved these changes Dec 14, 2019

@christopheNan christopheNan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Juste un adjectif à accorder et c'est bon pour moi.

Comment thread library/unittest.po Outdated
Co-Authored-By: Christophe Nanteuil <35002064+christopheNan@users.noreply.github.com>
@Seluj78

Seluj78 commented Dec 14, 2019

Copy link
Copy Markdown
Collaborator Author

@christopheNan vu que j'ai commit ta suggestion il me faut une nouvelle approbation

@christopheNan christopheNan merged commit 1a8eaca into python:3.8 Dec 15, 2019
@Seluj78 Seluj78 deleted the fuzzies-unittest branch December 15, 2019 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants